bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/6] canonicalize: fix EOVERFLOW bug


From: Paul Eggert
Subject: Re: [PATCH 2/6] canonicalize: fix EOVERFLOW bug
Date: Thu, 17 Dec 2020 02:03:34 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0

On 12/14/20 10:05 AM, Bruno Haible wrote:

But canonicalize-lgpl.c had similar changes, and it has a similar failure
on AIX 7.2, still today:

   ../../gltests/test-canonicalize-lgpl.c:100: assertion 'result == NULL' failed
   FAIL test-canonicalize-lgpl (exit status: 134)

Probably your changes to canonicalize.c could be applied to canonicalize-lgpl.c.

Thanks for mentioning that. While looking into it, I discovered several other correctness problems with canonicalize and canonicalize-lgpl in rare situations, and after looking at both of them for a while (along with glibc stdlib/canonicalize.c) decided to also lessen the differences between glibc and Gnulib to make a merge easier, and eventually came up with the attached patches, which I installed into Gnulib. The last patch fixes the AIX bug you mentioned.

These patches assume the 'free' patch I installed an hour or so ago, so that 'free' preserves errno.

I plan to reply to Adhemerval shortly.

Attachment: 0001-canonicalize-lgpl-simplify-merge-to-glibc.patch
Description: Text Data

Attachment: 0002-canonicalize-remove-arbitrary-8192-byte-limit.patch
Description: Text Data

Attachment: 0003-canonicalize-omit-second-readlink-when-not-needed.patch
Description: Text Data

Attachment: 0004-canonicalize-lgpl-fix-AIX-test-failures.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]