[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: stack module
|
From: |
Bruno Haible |
|
Subject: |
Re: stack module |
|
Date: |
Sat, 10 Oct 2020 16:06:36 +0200 |
|
User-agent: |
KMail/5.1.3 (Linux/4.4.0-189-generic; KDE/5.18.0; x86_64; ; ) |
Hi Marc,
> please see the attached patch for the new module.
Very nice. Looks all good, except for some nit-picking in the comments:
> + Introspection: ELEMENT *base = stack_base (&stack);
I would add a comment here:
Where ELEMENT is the type to which GL_STACK_ELEMENT was defined when
this file was included.
(It would be tempting to write
GL_STACK_ELEMENT *base = stack_base (&stack);
but GL_STACK_ELEMENT is no longer defined after the file was included...)
Other than that, please feel free to commit and push this. Thanks!!
Bruno