|
From: | Philippe Michel |
Subject: | Re: [Bug-gnubg] MS Windows / Multi-Threading / Code simplification |
Date: | Fri, 16 Jan 2015 23:48:14 +0100 (CET) |
User-agent: | Alpine 2.11 (BSF 23 2013-08-11) |
On Fri, 16 Jan 2015, Michael Petch wrote:
Yes I know those ifdefs well. Currently I build MS Windows releases using GLIB 2.24 (or there abouts) and developers like Philippe Michel still do builds on older CentoOS/RHEL systems where GLIB and GTK may both be quite bit older. When GLIB 2.32.0 came around they made a number of major changes. The Ifdefs (as you observed) are to retain compatibility with older GLIB versions. If we remove them we limit the versions we can target. I haven't checked in a while but I think we pretty much support any GLIB version above 2.0 and any GTK2(Not GTK3) version above about 2.12 (or maybe it was 2.14).
On the "older" CentOS releases, glib is at 2.12 (CentOS 5) and 2.16 (CentOS 6). I don't care much for rel. 5 but do for rel. 6.
This is quite close and well below 2.32 anyway. On the other hand, if there is an onerous work around somewhere for something available in glib 2.16 but not in 2.12, dropping support for CentOS 5 wouldn't bother me.
A similar thing applies to supporting Python2 and Python3. I consider this less of an issue since the Python code is limited to a small section of the code base and I have a feeling that people will be supporting both Python2 (2.5+) and Python3 for quite some time.
configure.ac requires python 2.2 or higher. This could probably be raised a little. I think I noticed conditional code for python <= 2.3 or something like that in one or two places, but the simplification would be limited.
[Prev in Thread] | Current Thread | [Next in Thread] |