|
From: | Michael Petch |
Subject: | Re: [Bug-gnubg] gnubg bug? change to getLuckRating() (gnubg-source-SNAPSHOT-20110729) |
Date: | Fri, 29 Jul 2011 11:50:14 -0600 |
User-agent: | Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11 |
On 29/07/2011 8:15 AM, pck wrote:
Thanks for the bug report. I have fixed it and will appear in a new build of code this weekend. I am a bit perplexed at how the original codes hard coded values were derived. Although a factor of 10 makes it more in line than it use to be its not the same (.02 != .03) so now the output differs a bit to previously releases. Hard coded value use to be .02 and now based on the defaults of .3 we went from a factor 15 change to factor 10 for BAD/GOOD/NONE. The old code was: if ( rLuck < -0.06 ) return LUCK_VERYBAD; else if ( rLuck < -0.02 ) return LUCK_BAD; else if ( rLuck < +0.02 ) return LUCK_NONE; else if ( rLuck < +0.06 ) return LUCK_GOOD; else return LUCK_VERYGOOD; We have 2 choices long term. Stick with a factor 10 difference for all values (As the new code is with the fix). Or go back to the original code as it is above where hard coded values are used and are independent of the thresholds set in the GUI -- Michael Petch CApp::Sysware Consulting Ltd. OpenPGP FingerPrint=D81C 6A0D 987E 7DA5 3219 6715 466A 2ACE 5CAE 3304 |
[Prev in Thread] | Current Thread | [Next in Thread] |