bug-gnu-libiconv
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gnu-libiconv] genaliases - file open in binary not text mode


From: Mike Fulton
Subject: Re: [bug-gnu-libiconv] genaliases - file open in binary not text mode
Date: Wed, 17 May 2023 13:56:04 -0700



On Wed, May 17, 2023 at 12:50 PM Bruno Haible <bruno@clisp.org> wrote:
Hi Mike,

> On z/OS, we tag files that are created with the code page they should use
> when the file is created in 'text' mode, but we don't do any tagging if the
> files are created in 'binary' mode.
>
> This causes grief in genaliases.c
>
> I would like to propose a small patch to create these files in text rather
> than binary

This is OK for z/OS, if you say so. But...

> - I don't believe this would create any issues on non-z/OS systems

The purpose of this use of binary mode is to avoid issues on Cygwin.
https://git.savannah.gnu.org/gitweb/?p=libiconv.git;a=commitdiff;h=555ccdd7f6479cfbb5ef7c74f64316611c357058

> Here's the proposed patch:

I've pushed a different patch instead, one that doesn't regress on Cygwin.
That patch will work! Thank you. 

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]