Re: [bug-gnu-libiconv] [PATCH 0/1] drop out versions from autotools programs

[Petr Ovtchenkov]

On Sun, 05 Apr 2020 13:12:55 +0200
Bruno Haible <address@hidden> wrote:

> Hi Petr,
> 
> > Looks that requirement of precise versions of autotools
> > is too strong. It is fine for other versions too.  
> 
> Yes, but adding the version suffix makes sure I and you use an
> up-to-date automake version, and I don't mistakenly make a release
> with an outdated automake version (like I already did a release with
> an outdated gperf version).

Hmm, and drop out newer autotools, that _not install_
autoconf-{version}/autoheader-{version}.

<snip>
 # autoconf --version
autoconf (GNU Autoconf) 2.69.209-8a09-dirty
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+/Autoconf: GNU GPL version 3 or later
<https://gnu.org/licenses/gpl.html>,
 <https://gnu.org/licenses/exceptions.html> This is free software: you
 are free to change and redistribute it. There is NO WARRANTY, to the
 extent permitted by law.
</snip>

> 
> > ltmain.sh will come from autotools, no needs to keep it here,
> > autotools will re-write it.  
> 
> No, this is wrong for two reasons:
>   - libtool.m4 would not be found if automake was installed with a
>     different --prefix than libtool.

Installation of automake is a problem of installation automake, IMO.

>   - We need a patched libtool, see
>     
> https://git.savannah.gnu.org/gitweb/?p=libiconv.git;a=commitdiff;h=b12cf8e93bc39f10bc134004de45d5f4a1ec9bac

libtool will owerwrite it in any case.

<snip>
  root@void-ptr# ls -laF build-aux/
  total 12
  drwxrwxr-x  2 105 105 4096 Apr  5 15:59 ./
  drwxrwxr-x 19 105 105 4096 Apr  5 15:57 ../
  -rwxrwxr-x  1 105 105 3423 Mar 19 15:05 mkinstalldirs*
  root@void-ptr# libtoolize
  libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
  libtoolize: linking file 'build-aux/ltmain.sh'
  libtoolize: You should add the contents of the following files to
  'aclocal.m4': libtoolize:   '/usr/share/aclocal/libtool.m4'
  libtoolize:   '/usr/share/aclocal/ltoptions.m4'
  libtoolize:   '/usr/share/aclocal/ltsugar.m4'
  libtoolize:   '/usr/share/aclocal/ltversion.m4'
  libtoolize:   '/usr/share/aclocal/lt~obsolete.m4'
  libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([m4])' to
  configure.ac, libtoolize: and rerunning libtoolize and aclocal.
  libtoolize: Consider adding '-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
  root@void-ptr# ls -laF build-aux/
  total 12
  drwxrwxr-x  2  105  105 4096 Apr  5 15:59 ./
  drwxrwxr-x 19  105  105 4096 Apr  5 15:57 ../
  lrwxrwxrwx  1 root root   38 Apr  5 15:59 ltmain.sh ->
  /usr/share/libtool/build-aux/ltmain.sh -rwxrwxr-x  1  105  105 3423
  Mar 19 15:05 mkinstalldirs*
</snip>

So patched ltmain.sh or absent---there is no difference.

--

   - ptr