[bug-gnu-libiconv] './check-stateless . ASCII' error during 'make check' run for MSVC builds on Windows

[sav_ix]

Hi, everyone,

For libiconv tests build using ICC and MSVC on Windows got errors:

(INSTALLDIR="$PWD/../MSVC64DH" PATH="$(cygpath -u $PATHTOGCC/bin):$PATH"
 && (CC="cl" CFLAGS="-MDd -DUNICODE" CXX="cl" CXXFLAGS="-MDd" 
LD="link" ./configure --prefix="$INSTALLDIR" --enable-shared 
--disable-static >_configure.log && make >_make.log 
&& make check >_check.log && make install 
>_install.log) 2>_stderr.log && cp *.log "$INSTALLDIR")

[snip]

test-to-wchar.c
/bin/sh
 ../libtool --mode=link /c/libLIBICONV-1.15/build/build-aux/compile cl  
-MDd -DUNICODE test-to-wchar.obj ../srclib/libicrt.a ../lib/libiconv.la 
-o test-to-wchar
libtool: link: 
/c/libLIBICONV-1.15/build/build-aux/compile cl -MDd -DUNICODE 
test-to-wchar.obj ../srclib/libicrt.a -o .libs/test-to-wchar  
../lib/.libs/iconv.dll.lib
Microsoft (R) C/C++ Optimizing Compiler Version 19.00.24210 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

cl : Command line warning D9024 : unrecognized source file type '../srclib/libicrt.a', object file assumed
Microsoft (R) Incremental Linker Version 14.00.24210.0
Copyright (C) Microsoft Corporation.  All rights reserved.

/out:.libs/test-to-wchar.exe
test-to-wchar.obj
../srclib/libicrt.a
../lib/.libs/iconv.dll.lib
libtool: link: lt_outputfile=".libs/test-to-wchar"
libtool: link:  lt_tool_outputfile=".libs\test-to-wchar"
libtool:
 link:  case .libs/test-to-wchar in *.exe|*.EXE) ;; *) 
lt_outputfile=.libs/test-to-wchar.exe 
lt_tool_outputfile=.libs\test-to-wchar.exe ;; esac
libtool: link:  if
 test : != "mt" && test -f ".libs/test-to-wchar.exe.manifest"; 
then mt -manifest ".libstest-to-wchar.exe.manifest" 
-outputresource:".libstest-to-wchar.exe" || exit 1; rm -f 
".libs/test-to-wchar.exe.manifest"; fi
Microsoft (R) C/C++ Optimizing Compiler Version 19.00.24210 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

lt-test-to-wchar.c
Microsoft (R) Incremental Linker Version 14.00.24210.0
Copyright (C) Microsoft Corporation.  All rights reserved.

/out:./test-to-wchar.exe
lt-test-to-wchar.obj
./check-stateless . ASCII
make[1]: *** [Makefile:32: check] Error 127
make[1]: Leaving directory '/c/libLIBICONV-1.15/build/tests'
make: *** [Makefile:101: check] Error 2

Reproduced for <ICC|MSVC><Debug|Release><Shared> builds only, if CFLAGS variable contain key '-DUNICODE'. Files
gengb18030z.obj
genutf8.obj
are also missing in 'libLIBICONV-1.15/tests/' build directory, compared to builds without this key.

Environment:
- Windows 10 x64,
- ICC 2017,
- MSVC 2015,
- mingw-w64 6.3.0,
- MSYS2 20161025,
- libiconv-1.15.

Not sure whether it's an error of <ICC|MSVC> or a flaw in libiconv testsuite. But '-DUNICODE' is a default key for MESA, QT and other libraries builds using MSVC. Would be nice to use it for libiconv too. This allow to make builds of all this libraries with the same build options.

P.S. The above libiconv build was made in slightly different way than described in README.windows manual. To accomplish it an additional patch required (see attachment).


Alexander

libiconv_msvc_shared.diff
Description: Binary data