Re: [bug-gnu-libiconv] libiconv 1.14 regression test failure

[Bruno Haible]

Christian Weisgerber wrote:
> If the build directory is different from the source directory, libiconv
> 1.14's regression tests will fail.
> 
> The problem is the GB18030 test:
> 
>         $(CC) $(LDFLAGS) $(INCLUDES) $(CFLAGS) $(CPPFLAGS) 
> $(srcdir)/gengb18030z.c ../srclib/libicrt.a -o gengb18030z && \
>         { cat $(srcdir)/GB18030-BMP.TXT ; ./gengb18030z ; } | sort > 
> GB18030.TXT && \
>         $(srcdir)/check-stateless . GB18030 && \
>         $(RM) -r address@hidden@ gengb18030z.dSYM GB18030.TXT
> 
> This calls check-stateless with the build directory path ".", so
> it fails to find $(srcdir)/GB18030.IRREVERSIBLE.TXT.

Thanks for the report. I'll use this fix:


2011-09-02  Bruno Haible  <address@hidden>

        Fix "make check" failure when $(srcdir) != $(builddir).
        * tests/Makefile.in (check): When $(srcdir) != ., temporarily copy
        GB18030.IRREVERSIBLE.TXT into the build directory.
        Reported by Christian Weisgerber <address@hidden>.

--- tests/Makefile.in.orig      Fri Sep  2 21:32:31 2011
+++ tests/Makefile.in   Fri Sep  2 21:28:14 2011
@@ -128,7 +128,9 @@
        $(srcdir)/check-stateless $(srcdir) CP936
        $(CC) $(LDFLAGS) $(INCLUDES) $(CFLAGS) $(CPPFLAGS) 
$(srcdir)/gengb18030z.c ../srclib/libicrt.a -o gengb18030z && \
        { cat $(srcdir)/GB18030-BMP.TXT ; ./gengb18030z ; } | sort > 
GB18030.TXT && \
+       { test $(srcdir) = . || cp $(srcdir)/GB18030.IRREVERSIBLE.TXT 
GB18030.IRREVERSIBLE.TXT; } && \
        $(srcdir)/check-stateless . GB18030 && \
+       { test $(srcdir) = . || $(RM) GB18030.IRREVERSIBLE.TXT; } && \
        $(RM) -r address@hidden@ gengb18030z.dSYM GB18030.TXT
        $(srcdir)/check-stateful $(srcdir) ISO-2022-CN
        $(srcdir)/check-stateful $(srcdir) ISO-2022-CN-EXT
-- 
In memoriam Robert Mensah <http://en.wikipedia.org/wiki/Robert_Mensah>