bug-gnu-libiconv
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug-gnu-libiconv] libiconv 1.14 regression test failure


From: Christian Weisgerber
Subject: [bug-gnu-libiconv] libiconv 1.14 regression test failure
Date: Thu, 1 Sep 2011 21:49:12 +0200
User-agent: Mutt/1.4.2.3i

If the build directory is different from the source directory, libiconv
1.14's regression tests will fail.

The problem is the GB18030 test:

        $(CC) $(LDFLAGS) $(INCLUDES) $(CFLAGS) $(CPPFLAGS) 
$(srcdir)/gengb18030z.c ../srclib/libicrt.a -o gengb18030z && \
        { cat $(srcdir)/GB18030-BMP.TXT ; ./gengb18030z ; } | sort > 
GB18030.TXT && \
        $(srcdir)/check-stateless . GB18030 && \
        $(RM) -r address@hidden@ gengb18030z.dSYM GB18030.TXT

This calls check-stateless with the build directory path ".", so
it fails to find $(srcdir)/GB18030.IRREVERSIBLE.TXT.


I've used the band-aid below, but that's probably not quite right.

--- tests/Makefile.in.orig      Thu Sep  1 21:38:16 2011
+++ tests/Makefile.in   Thu Sep  1 21:42:16 2011
@@ -126,7 +126,7 @@ check : all table-from table-to ../src/iconv_no_i18n t
        $(srcdir)/check-stateless $(srcdir) EUC-CN
        $(srcdir)/check-stateless $(srcdir) GBK
        $(srcdir)/check-stateless $(srcdir) CP936
-       $(CC) $(LDFLAGS) $(INCLUDES) $(CFLAGS) $(CPPFLAGS) 
$(srcdir)/gengb18030z.c ../srclib/libicrt.a -o gengb18030z && \
+       test $(srcdir) != . && cp $(srcdir)/GB18030.IRREVERSIBLE.TXT . ; $(CC) 
$(LDFLAGS) $(INCLUDES) $(CFLAGS) $(CPPFLAGS) $(srcdir)/gengb18030z.c 
../srclib/libicrt.a -o gengb18030z && \
        { cat $(srcdir)/GB18030-BMP.TXT ; ./gengb18030z ; } | sort > 
GB18030.TXT && \
        $(srcdir)/check-stateless . GB18030 && \
        $(RM) -r address@hidden@ gengb18030z.dSYM GB18030.TXT
-- 
Christian "naddy" Weisgerber                          address@hidden



reply via email to

[Prev in Thread] Current Thread [Next in Thread]