Re: [bug-gnu-libiconv] ISO 646

[John Briggs]

Thanks for your reply Bruno.

ISO 646 may be superseded, but it is the default on a sample of the 
Solaris sparc/x86 hosts that I have access to including those that I 
have not built.

Examples:
address@hidden:/# uname -a
SunOS sstcifmgt001.ntcif 5.7 Generic_106541-11 sun4u sparc SUNW,Ultra-4
address@hidden:/# locale -k charmap
charmap="646"

address@hidden:/# uname -a
SunOS susid007 5.8 Generic_117350-14 sun4u sparc SUNW,Ultra-60 Solaris
address@hidden:/# locale -k charmap
charmap="646"

address@hidden:~# uname -a
SunOS ammit 5.10 Generic_127127-11 sun4u sparc SUNW,Sun-Blade-100 Solaris
address@hidden:~# locale -k charmap
charmap="646"

And just for reference, a Linux OS
address@hidden:~# uname -a
Linux lxltsdpog001 2.6.9-55.ELsmp #1 SMP Fri Apr 20 16:36:54 EDT 2007 
x86_64 x86_64 x86_64 GNU/Linux
address@hidden:~# locale -k charmap
charmap="UTF-8"

So when an app like mplayer uses libiconv there is an error:
iconv: conversion from UTF-8 to 646 unsupported

So I have added:

rcsdiff -c -r1.1 mp_msg.c
===================================================================
RCS file: mp_msg.c,v
retrieving revision 1.1
diff -c -r1.1 mp_msg.c
*** /tmp/T0Hja4PC       Thu Jun 26 12:32:04 2008
--- mp_msg.c    Wed Jun 25 17:15:11 2008
***************
*** 111,116 ****
--- 111,121 ----
 #endif

 #if defined(USE_ICONV) && defined(MSG_CHARSET)
+ #if defined(__sun)
+     if (mp_msg_charset && strcasecmp(mp_msg_charset, "UTF-8")) {
+       mp_msg_charset = "ASCII";
+     }
+ #endif
     if (mp_msg_charset && strcasecmp(mp_msg_charset, "noconv")) {
       char tmp2[MSGSIZE_MAX];
       size_t inlen = strlen(tmp), outlen = MSGSIZE_MAX;

Off hand I cant remember the other app I modified - was a while back. 
But may be able to dig it up if need be.
-John