[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#67527: 30.0.50; FR: Add an option to disable ispell completion in te
From: |
Eli Zaretskii |
Subject: |
bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode |
Date: |
Sat, 27 Jan 2024 11:56:24 +0200 |
> From: Eshel Yaron <me@eshelyaron.com>
> Cc: Daniel Mendler <mail@daniel-mendler.de>, aqua0210@foxmail.com,
> 67527@debbugs.gnu.org, simon@ecksd.com
> Date: Sat, 20 Jan 2024 12:33:25 +0100
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Daniel Mendler <mail@daniel-mendler.de>
> >>
> >> Eli Zaretskii <eliz@gnu.org> writes:
> >>
> >> >> From: Daniel Mendler <mail@daniel-mendler.de>
> >> >>
> >> >> Eli Zaretskii <eliz@gnu.org> writes:
> >> >>
> >> >> > Eshel, given this feedback, I think it would make sense to add a new
> >> >> > defcustom that would make text-mode avoid adding
> >> >> > ispell-completion-at-point to completion-at-point-functions. Would
> >> >> > you please submit such a change and the documentation changes to go
> >> >> > with it? TIA.
> >> >>
> >> >> Maybe the existing defcustom `text-mode-meta-tab-ispell-complete-word'
> >> >> could be renamed and reused, taking three values? This way we avoid
> >> >> introducing multiple defcustoms for tweaking the same feature.
> >> >>
> >> >> - `command': Bind `ispell-complete-word' to TAB.
> >> >> - `capf': Add `ispell-completion-at-point' to the
> >> >> `completion-at-point-functions'.
> >> >> - `nil': None of the above.
> >> >
> >> > Reused, yes. Renamed, I'd rather prefer we avoided that, as it causes
> >> > compatibility problems. If we can extend its list of valid values to
> >> > support this aspect as well, it would be good.
> >>
> >> Iiuc the variable was introduced a short while ago on Emacs master, so
> >> renaming it may still be possible?
> >
> > Oh, I think I confused it with another option. Yes, if it was
> > introduced recently on master, we can rename it.
>
> SGTM, see attached patch below.
Thanks, installed on master, and closing the bug.
- bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode, (continued)
- bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode, Eli Zaretskii, 2024/01/09
- bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode, Eason Huang, 2024/01/12
- bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode, Eli Zaretskii, 2024/01/12
- bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode, Eason Huang, 2024/01/13
- bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode, Eli Zaretskii, 2024/01/20
- bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode, Daniel Mendler, 2024/01/20
- bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode, Eli Zaretskii, 2024/01/20
- bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode, Daniel Mendler, 2024/01/20
- bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode, Eli Zaretskii, 2024/01/20
- bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode, Eshel Yaron, 2024/01/20
- bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode,
Eli Zaretskii <=