bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#68214: Completion sorting customization by category


From: Juri Linkov
Subject: bug#68214: Completion sorting customization by category
Date: Sun, 07 Jan 2024 20:05:27 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)

>> This is what I already considered but hesitated to make this change
>> since it modifies the default behavior.  OTOH, probably there is
>> no possible harm from this change.  So I'll give this a try.
>
> Thanks. Seems better to take that route, instead of changing all
> `completion-metadata-get' calls to `completion-metadata-override-get'
> and leaving `completion-metadata-get' mostly unused. As long as we don't
> modify `completion-category-defaults' or `completion-category-overrides'
> there won't be a change in behavior.

Thanks for the suggestion.  Now pushed in commit 18de131222e,
so all metadata properties are supported now in
`completion-category-overrides'.

What do you think about doing the same for
`completion-extra-properties'?

This basically means moving `plist-get completion-extra-properties'
to `completion-metadata-get' that will replace this:

  (ann-fun (or (completion-metadata-get all-md 'annotation-function)
               (plist-get completion-extra-properties
                          :annotation-function)))
  (aff-fun (or (completion-metadata-get all-md 'affixation-function)
               (plist-get completion-extra-properties
                          :affixation-function)))

with just:

  (ann-fun (completion-metadata-get all-md 'annotation-function))
  (aff-fun (completion-metadata-get all-md 'affixation-function))





reply via email to

[Prev in Thread] Current Thread [Next in Thread]