[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#68294: [PATCH] Set the 'name' prop in 'define-advice'
From: |
Eli Zaretskii |
Subject: |
bug#68294: [PATCH] Set the 'name' prop in 'define-advice' |
Date: |
Sun, 07 Jan 2024 08:27:03 +0200 |
> From: Steven Allen <steven@stebalien.com>
> Date: Sat, 06 Jan 2024 09:54:36 -0800
>
> In addition to naming the advice function 'symbol@name', set the 'name'
> property to NAME. The code should be good, but I'm less sure about the
> updated documentation.
>
> Requested in Bug#68114.
Stefan, any comments?
> @defmac define-advice symbol (where lambda-list &optional name depth) &rest
> body
> This macro defines a piece of advice and adds it to the function named
> -@var{symbol}. The advice is an anonymous function if @var{name} is
> -@code{nil} or a function named @code{symbol@@name}. See
> -@code{advice-add} for explanation of other arguments.
> +@var{symbol}. If @var{name} is non-nil, the advice is named
> +@code{symbol@@name} and installed with the name @var{name}; otherwise,
^^^^^^^^^^^^^^^^^^^
This should be @code{@var{symbol}@@@var{name}}.
> +** 'define-advice' now sets the new advice's 'name' property to NAME
> +Named advice defined with 'define-advice' can now be remove with
^^^^^^
This should be "removed".