[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#66902: 30.0.50; Recognize env -S/--split-string in shebangs
From: |
Kévin Le Gouguec |
Subject: |
bug#66902: 30.0.50; Recognize env -S/--split-string in shebangs |
Date: |
Sat, 18 Nov 2023 11:31:29 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Kévin Le Gouguec <kevin.legouguec@gmail.com>
>> Date: Sun, 12 Nov 2023 18:53:40 +0100
>>
>> > 3. Assuming we do want to amend that regexp, would it be possible to use
>> > rx here? OT1H guessing "no" because files.el is pre-reloaded, whereas
>> > rx.el is not; OTOH I see that files.el requires easy-mmode at
>> > compile-time, and that package does not show up in loadup.el, so…
>> > settling for "maybe?"
>>
>> Figured rx was similar to pcase in that regard:
>>
>> * They need to be required explicitly despite their macros being
>> "autoloaded", because files.el is loaded during bootstrap before
>> autoloading is set up.
>>
>> * Somehow that does not cause them to be preloaded? At least going by
>> emacs -Q,
>> * featurep returns nil,
>> * preloaded-file-list does not include them.
>
> I'd prefer not to have rx required in files.el, so could you please
> rewrite those parts of your patch and resubmit? Also, please add a
> NEWS entry about the change.
ACK; will get to it in the coming days.
> I think otherwise your patch is ready to
> go in.
>
> Thanks.
Thank you for the review!