[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63469: 29.0.90; project.el doesn't add menu-bar entries
From: |
Juri Linkov |
Subject: |
bug#63469: 29.0.90; project.el doesn't add menu-bar entries |
Date: |
Thu, 25 May 2023 21:41:32 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) |
>>> -(cl-defmethod project-name ((_project (head vc)))
>>> - (or project-vc-name
>>> +(cl-defmethod project-name ((project (head vc)))
>>> + (or (project--value-in-dir 'project-vc-name (project-root project))
>>> (cl-call-next-method)))
>> Thanks, I confirm this uses project-vc-name from dir-locals in non-file
>> buffers.
>
> If you had a chance to verify that the performance is good enough (for
> using the result in the mode-line), that would be great.
>
> Either way...
>
>>>> ;;;###autoload(put 'compilation-directory 'safe-local-variable 'stringp)
>>>
>>> Huh, so the attribute :safe only makes proper sense for preloaded packages
>>> and autoloaded defcustom forms (which are discouraged anyway).
>>>
>>> Do you want to write a patch for all those vars in project.el? It will
>>> probably make sense to push it to emacs-29.
>> With this patch the problem is solved. I can push it to emacs-29.
>
> ...this patch LGTM too. Please go ahead and install it, or even both
> patches.
I pushed ###autoload to emacs-29. But not sure about your patch
since currently I have no idea how to verify its performance.
Maybe it should be pushed to master so that everyone can test it?
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, (continued)
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Dmitry Gutov, 2023/05/25
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Juri Linkov, 2023/05/23
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Dmitry Gutov, 2023/05/22
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Juri Linkov, 2023/05/23
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Juri Linkov, 2023/05/23
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Dmitry Gutov, 2023/05/23
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Juri Linkov, 2023/05/24
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Dmitry Gutov, 2023/05/24
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Juri Linkov, 2023/05/25
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Dmitry Gutov, 2023/05/25
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries,
Juri Linkov <=
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Dmitry Gutov, 2023/05/25
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Juri Linkov, 2023/05/30
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Dmitry Gutov, 2023/05/23
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Spencer Baugh, 2023/05/19
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Juri Linkov, 2023/05/19