[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63690: 29.0.91; New vc commands missing on vc-menu
From: |
Eli Zaretskii |
Subject: |
bug#63690: 29.0.91; New vc commands missing on vc-menu |
Date: |
Wed, 24 May 2023 19:51:45 +0300 |
> From: Juri Linkov <juri@linkov.net>
> Date: Wed, 24 May 2023 19:16:23 +0300
>
> etc/NEWS on emacs-29 contains:
>
> 'vc-print-branch-log' is bound to 'C-x v b l', and new commands are
> 'vc-create-branch' ('C-x v b c') and 'vc-switch-branch' ('C-x v b s').
>
> But new commands are not yet added to 'vc-menu-map'.
> This patch for emacs-29 fixes this omission:
Thanks. This is okay, but the help-echo text "needs work".
> diff --git a/lisp/vc/vc-hooks.el b/lisp/vc/vc-hooks.el
> index 02c4a240c6a..402b918fc7d 100644
> --- a/lisp/vc/vc-hooks.el
> +++ b/lisp/vc/vc-hooks.el
> @@ -898,6 +927,15 @@ vc-menu-map
> (bindings--define-key map [vc-create-tag]
> '(menu-item "Create Tag" vc-create-tag
> :help "Create version tag"))
> + (bindings--define-key map [vc-print-branch-log]
> + '(menu-item "Show Branch History" vc-print-branch-log
> + :help "Show the change log for branch root"))
What is "branch root"?
> + (bindings--define-key map [vc-switch-branch]
> + '(menu-item "Switch Branch" vc-switch-branch
> + :help "Switch to the branch"))
"the" branch?
Also, AFAICT these commands are not described in the manual. If they
are important enough to be on the menu bar, I think we should mention
them in the manual as well, no?