[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63372: [PATCH] Add variable: eglot-apply-text-edits-function
From: |
Felician Nemeth |
Subject: |
bug#63372: [PATCH] Add variable: eglot-apply-text-edits-function |
Date: |
Mon, 08 May 2023 16:28:56 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
In https://lists.gnu.org/archive/html/emacs-devel/2023-05/msg00173.html
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Felician Nemeth <felician.nemeth@gmail.com>
>> Cc: joaotavora@gmail.com, emacs-devel@gnu.org
>> Date: Sat, 06 May 2023 17:17:14 +0200
>>
>> 3. Eglot uses the eglot--apply-text-edits defun to apply server
>> initiated edits. There is an extension that allows the server to
>> send the edits in a different format (snippet-text-edits).
>>
>> Eglot-x puts an advise on eglot--apply-text-edits to check the format
>> of the edits and act accordingly.
>>
>> I don't know how to avoid this advice.
>
> Some hook or function variable, perhaps? If they don't exist, perhaps
> they could be added?
I've attached a patch with my first attempt at this. João, what do you
think of this approach?
(Independently of this issue, maybe a configurable
apply-workspace-edit-function would be useful as well. One alternative
implementation of the current eglot--apply-workspace-edit could be to
apply all edits without asking for confirmation and then show a
`vc-diff'-like interface allowing the user to revert/accept all of the
changes with a single keystroke.)
Thank you.
0001-Add-variable-eglot-apply-text-edits-function.patch
Description: Text Data
- bug#63372: [PATCH] Add variable: eglot-apply-text-edits-function,
Felician Nemeth <=