bug#62694: 30.0.50; eglot-tests fails with recent pylsp

[João Távora]

On Thu, Apr 6, 2023, 12:22 Michael Albinus <michael.albinus@gmx.de> wrote:

> > Instead of using your distribution package manager, I recommend
> > installing pylsp via the official Python package manager, pip, and
> > doing it like so:
> >
> > pip install "python-lsp-server[all]"
>
> I disagree. Running regression tests towards bleeding edge development
> version of pylsp is not the intention. You cannot expect, that everybody
> running Emacs tests has installed pylsp like this. But she could have
> installed the Debian pylsp package.

Sure, or she has a 'pylsp' that prints the complete works of
Shakespeare. But these tests are designed for the number one
recommended pylsp installation method. It's AFAIK not the
"bleeding edge" (which would be a Git installation). And tests
have been running fine with that installation method for a
number of months now, maybe even years.

> I have used the most recent pylsp package from Debian. If it doesn't
> cooperate with eglot, we have a problem.

We? I'd say Debian has, right?  I don't have anything against it,
quite the contrary, but I don't have Debian, and I don't program
against it (that's also a reason why I can't debug this right now).

As I explained, eglot-tests.el, is just testing eglot.el's logic
and pylsp happens to be an easy server to install in most operating
systems that exercises some of eglot.el's functionality.

I can probably switch to tests to use some other server, maybe
one whose Debian package is more well-behaved, but this is
hardly a priority for me.

What/whose problem or scenario are you trying to solve?
Who is this hypothetical she-user and what is she trying
to do?  Develop Emacs, develop Eglot, run eglot tests, use
Eglot with python? All/some of the above?

What is preventing you or her from installing this external
tool using its recommended installation method?  Does Debian's
python not carry its 'pip' package manager? Why do you want to
install it, and why do you want to install it specifically like this?

> I recommend that you investigate why the tests fail. And if this sounds
> too much, at least the sanity checks shall be improved. (skip-unless
> (executable-find "pylsp")) doesn't seem to be sufficient then.

I don't have Debian.  We can overhaul the sanity checks, but I don't
immediately see how.  Or why.  So it's hardly a priority.

João