bug#53636: 29.0.50; face-remapping broken on master

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> Actually, I think this is a new problem on master, introduced by
> making the mode-line face be a parent of mode-line-active and
> mode-line-inactive faces.  When that was done, lookup_basic_face was
> changed to use mode-line-active instead of mode-line, so now the
> mode-line face is not recomputed when face-remapping-alist is changed.
> Instead, we recompute mode-line-active and mode-line-inactive, but
> those are not in face-remapping-alist in this scenario, so they don't
> change on the existing frame.

Ah, right.  So we should go back to also recomputing mode-line, I guess...

> Do we still need the mode-line as a parent of these two faces, or can
> we go back to what we had before the variable-pitch mode-line changes?

The plan is to reintroduce the variable-pitch stuff after we've ironed
out the width issues, so I'd rather keep the faces as is.  (And I think
it makes more sense conceptually, since `mode-line' is also used as the
parent of other faces, like `header-line'.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no