bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#30320: 26.0.91; Crash when using lsp-ui-doc-mode


From: Eli Zaretskii
Subject: bug#30320: 26.0.91; Crash when using lsp-ui-doc-mode
Date: Sun, 11 Feb 2018 17:43:13 +0200

> Date: Sun, 11 Feb 2018 10:36:10 +0100
> From: martin rudalics <rudalics@gmx.at>
> CC: jake.goulding@gmail.com, 30320@debbugs.gnu.org
> 
> --- a/src/frame.c
> +++ b/src/frame.c
> @@ -350,10 +350,13 @@ struct frame *
>    struct frame *f = XFRAME (frame);
>    Lisp_Object par_size;
>  
> -  if ((!NILP (horizontal)
> -       && NUMBERP (par_size = get_frame_param (f, Qmin_width)))
> -      || (NILP (horizontal)
> -       && NUMBERP (par_size = get_frame_param (f, Qmin_height))))
> +  /* The 'min-width' and 'min-height' parameters have no effect on TTY
> +     frames.  */
> +  if (!(FRAME_TERMCAP_P (f) || FRAME_MSDOS_P (f))
> +      && ((!NILP (horizontal)
> +        && NUMBERP (par_size = get_frame_param (f, Qmin_width)))
> +       || (NILP (horizontal)
> +           && NUMBERP (par_size = get_frame_param (f, Qmin_height)))))
>      {
>        int min_size = XINT (par_size);

So you are saying that frame-windows-min-size will never return too
small values, at least not for TTY frames?  If so, this LGTM, thanks.
I just hoped Jake would be able to test this with the original Lisp
that caused the problems.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]