[patch] libintl redefining sprintf creates issues

[Marc Jeanmougin]

Hi!
I have an issue with the redefinitions of sprintf in libintl.h on 
mingw64 because the "#define sprintf libintl_sprintf" does not take into 
account that sprintf is available in std, so when boost headers start 
referring to std::sprintf the compiler complains that 
std::libintl_sprintf does not exist...

When I reached out to boost* they recommended to include boost headers 
"before" whatever includes libintl (in my case, glib/gi18n) but that is 
not very maintainable.

My next best option is to "fix" gettext, I found a hack (patch attached) 
by just adding a "namespace std { using ::libintl_sprintf; }" within a 
#ifdef __cplusplus__ block just after the #define, which does work, but 
since it is in theory UB**, you may have other ideas which will probably 
have to get rid of the #define …

Thanks!

--
Marc

* https://github.com/boostorg/assert/issues/24
** https://en.cppreference.com/w/cpp/language/extending_std

0001-Make-libintl-printf-functions-available-in-std-names.patch
Description: Text Data

OpenPGP_0x5FCB204EF882B07A.asc
Description: OpenPGP public key

OpenPGP_signature
Description: OpenPGP digital signature