Re: [bug-gettext] gettext-0.20 has parallel make install issues

[Bruno Haible]

Hi Lars,

> We already got a patch that seems to fix parallel install as well:
> 
> https://gitweb.gentoo.org/repo/gentoo.git/plain/sys-devel/gettext/files/gettext-0.20-parallel_install.patch?id=f570cd6e3ccfa1b9afae0c875a367a55b75f8f1d
> 

> diff --git a/gettext-tools/src/Makefile.am b/gettext-tools/src/Makefile.am
> index 09a3c153d..1ee49cdca 100644
> --- a/gettext-tools/src/Makefile.am
> +++ b/gettext-tools/src/Makefile.am
> @@ -252,9 +252,16 @@ cldr_plurals_LDADD = libgettextsrc.la $(LDADD)
>  
>  # How to get the include files of libtextstyle.
>  textstyle.h textstyle/stdbool.h textstyle/version.h textstyle/woe32dll.h:
> -     here=`pwd`; \
> -     cd ../../libtextstyle/lib && \
> -       $(MAKE) install-nobase_includeHEADERS 
> install-nobase_nodist_includeHEADERS includedir="$$here"
> +     cd "$(abs_top_builddir)/../libtextstyle/lib" && $(MAKE) $@
> +     if test -f "$(abs_top_builddir)/../libtextstyle/lib/$@"; then \
> +             file="$(abs_top_builddir)/../libtextstyle/lib/$@"; \
> +     else \
> +             file="$(abs_top_srcdir)/../libtextstyle/lib/$@"; \
> +     fi; \
> +     target_dir="$(abs_builddir)/$@"; \
> +     target_dir="$${target_dir%/*}"; \
> +     $(MKDIR_P) "$${target_dir}"; \
> +     $(INSTALL_HEADER) "$$file" $@
>  BUILT_SOURCES    += textstyle.h textstyle/stdbool.h textstyle/version.h 
> textstyle/woe32dll.h
>  MOSTLYCLEANFILES += textstyle.h textstyle/stdbool.h textstyle/version.h 
> textstyle/woe32dll.h

> Is that acceptable for you?

No, this one copies too much logic from the libtextstyle/lib/ directory,
therefore creating a maintenance problem. It is already bad enough that
I have to duplicate the list of 4 files here. This patch would also copy
the information WHERE in libtextstyle's build tree the files reside and
HOW they should be copied.

If you have time to work on this issue, please use Miguel's patch as a
starting point. Also it would be good to fix the problem for the po-gram-gen.c
and cldr-plural.c rules.

Bruno