Re: [bug-gettext] [PATCH] OS/2 patches

[Daiki Ueno]

KO Myung-Hun <address@hidden> writes:

Thanks for the patches.  Some comments below.

> [PATCH 1/8] moop: Replace CR as well as NL with a space

I'm not sure who adds CR here.  Can't we assume that all source files
use NL line termination?  Or some other tools add CR on OS/2?  Also, I
worry about the portability of '\r' as an argument of tr.

> [PATCH 2/8] test-lock: Do not include sched.h on kLIBC
> [PATCH 3/8] build: Do not include os2compat.[ch]
> [PATCH 4/8] gettext-runtime: Fix name resolution failures on kLIBC

Those seem to be OK.

> [PATCH 5/8] intl: Support UNIXROOT in BINDTEXTDOMAIN () on EMX

Doesn't this conflict with the UNIXROOT resolution in os2compat.c?

Also, since it changes the calling convention of bindtextdomain(), which
previously assumed that it is user's responsibility to resolve DIRNAME,
doesn't it break existing programs?

> [PATCH 6/8] libasprintf: Build a shared library on OS/2
> [PATCH 7/8] gettext-tools: Use a short name for DLLs on OS/2

Those look a bit ugly, but should be OK.

> [PATCH 8/8] xgettext, cldr-plurals: Fix linkage on OS/2

After merging the ITS branch (wip/ueno/its2), I plan to replace the
libexpat dependencies with libxml2 (for tools) and a hand written XML
parser (for libgettextpo, maybe ported from GLib's gmarkup.c).  So this
shouldn't be necessary.

Regards,
-- 
Daiki Ueno