bug-gettext
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gettext] Bug#682580: xgettext: fails to properly replace some p


From: Francesco Poli
Subject: Re: [bug-gettext] Bug#682580: xgettext: fails to properly replace some placeholders in output .pot (PACKAGE, YEAR, C. HOLDER) (fwd)
Date: Mon, 24 Aug 2015 20:48:24 +0200

On Mon, 24 Aug 2015 18:05:17 +0900 Daiki Ueno wrote:

> Francesco Poli <address@hidden> writes:
> 
> > Besides that, the patch seems to only address point (B) of my original
> > bug report (multiple copyright holders), but not point (A) or point (C)
> > (YEAR and PACKAGE placeholders). Or am I misreading the patch?
> 
> As (C) is trivial, I've pushed a fix:
> http://git.savannah.gnu.org/cgit/gettext.git/commit/?id=3a08add5

Many thanks for doing so!  :-)

> 
> However, I have not yet decided how to fix (A).  A few options I have in
> mind are:
[...]
> 
> 3. add a new option, say --add-copyright, which takes an argument in the
>   form "YEAR COPYRIGHT_HOLDER".
[...]
> 
> Suggestions would be appreciated.

I'd definitely vote for 3, but, wait!, even better, I would add a new
option named --copyright-notices (or maybe there's a better name, I
don't know...), where all the copyright notices may be specified with
their own line breaks, as in:


  $ xgettext --copyright-notices="Copyright (C) 2001-2012 Python Software 
Foundation.
    Copyright (C) 2000 BeOpen.com.
    Copyright (C) 1995-2000 Corporation for National Research Initiatives.
    Copyright (C) 1991-1995 Stichting Mathematisch Centrum." \
             --package-name=myapplication --package-version=0.1 \
             --language=python myapplication.py -o myapplication2.pot

This would cause myapplication2.pot to include:

  # Copyright (C) 2001-2012 Python Software Foundation.
  # Copyright (C) 2000 BeOpen.com.
  # Copyright (C) 1995-2000 Corporation for National Research Initiatives.
  # Copyright (C) 1991-1995 Stichting Mathematisch Centrum.

in stead of:

  # Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER

In other words, the --copyright-notice option would allow the user to
specify the copyright notices literally; xgettext would just prepend
each copyright notice line with the "# " comment symbol.


Does it sound like a good suggestion?

-- 
 http://www.inventati.org/frx/
 There's not a second to spare! To the laboratory!
..................................................... Francesco Poli .
 GnuPG key fpr == CA01 1147 9CD2 EFDF FB82  3925 3E1C 27E1 1F69 BFFE

Attachment: pgp_nlX_Jg_ti.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]