Re: [bug-gettext] intl: Proof against invalid offset/length

[Daiki Ueno]

"Carlos O'Donell" <address@hidden> writes:

> On 03/13/2015 10:29 AM, Florian Weimer wrote:
>> On 03/12/2015 02:04 AM, Bruno Haible wrote:
>> 
>>> But these arguments don't consider the LANGUAGE variable. The original
>>> intent of LANGUAGE was that it contains colon-separated language or locale
>>> identifiers. But in fact, you can specify relative files names that start
>>> with "../", and thus you can make the _nl_load_domain function in glibc
>>> access files anywhere in the file system.
>> 
>> Yes, this is bug 17142.
>
> In my opinion we need to restrict LANGUAGE just like we restricted all
> other the other variables in CVE-2014-0475.

I agree.  Now that intl/ is almost[1] synchronized with gettext, what's
blocking this?  I'm happy to include the patch in the upcoming gettext
release so non-glibc consumers also benefit from it.

Footnotes: 
[1]  except a minor adjustment for non-glibc systems:
     https://lists.gnu.org/archive/html/bug-gettext/2015-01/msg00029.html
     and absolute pathname handling, which I guess could be reverted because
     of not much use:
     http://git.savannah.gnu.org/cgit/gettext.git/commit/?id=279b57fc

Regards,
-- 
Daiki Ueno