Re: [bug-gettext] [PATCH 2/3] xgettext: allow file name extension with multiple dots

[Miguel Ángel Arruga Vivas]

Hi,

I must sleep, but I have seen some tabs. ;)
There is a commit[1] that suggests only-space policy, although It is a
personal issue, so this is actually a comment, not a review.

Daiki Ueno <address@hidden>: 
> +       const char *p;
Here.

> +       for (p = reduced + strlen (reduced); p > reduced; p--)
> +         {
> +           if (*p == '.')
> +             {
> +               extension = p + 1;
> +
> +               /* Derive the language from the extension, and the extractor
> +                  function from the language.  */
> +               language = extension_to_language (extension);
> +             }
> +         }
Also here.

> +           extension = strrchr (reduced, '.');
> +           if (extension == NULL)
> +             extension = "";
> +           else
> +             extension++;
And here.

Best regards,
Miguel

[1] commit 27c9575edba700ec429619293aa46564eb36b06b
Author: Bruno Haible <address@hidden>
Date:   Thu Jun 3 14:42:54 2010 +0200

    Untabify.