Re: [bug-gettext] [RFC Patch] Implement \u support in xgettext for C family (C11/C++11)

[Daiki Ueno]

Hi Miguel,

Miguel Ángel <address@hidden> writes:

> I have implemented a very basic support for escaped unicode code
> points.

Cool.  I haven't had time to review formally but some comments are
below.

> +#define P7_UNICODE (1000 + 'u')

Isn't it possible to skip Unicode escapes in 'phase7_getc', instead of
'phase5_get'?  Like the Python parser?

> I am not very sure if I have to change always
> 'xgettext_current_source_encoding'. I have looked into x-java.c code.

The patch sets 'xgettext_current_source_encoding' to UTF-8 when it
detects Unicode escapes.  I guess it only works if the source code
encoding (see "gcc -finput-charset") is UTF-8.

I'm also not very sure how to handle this case though, maybe we should
adjust to 'xgettext_global_source_encoding', if it is not ASCII?

> I also have to extend testsuite, because I have tested it with simple
> files and my current make check (with GtkBuilder support).

Nice.  A minor thing, it might be good to use spaces consistently in the
source code.

Regards,
-- 
Daiki Ueno