[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-gcal] Update to Swedish holidays
From: |
Giuseppe Scrivano |
Subject: |
Re: [Bug-gcal] Update to Swedish holidays |
Date: |
Mon, 13 Jun 2016 23:21:36 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Hi Göran,
Göran Uddeborg <address@hidden> writes:
> Giuseppe Scrivano:
>> not sure, but if it is in base but not valid for Sweden, then I think
>> you should modify it in the base function to not be added for Sweden and
>> later add it only for Sweden with the different values. Would that work
>> for you?
>
> It would work, but it becomes a bit messy since it affects the
> signature of the function, and thus all calls. See the attached
> possible patch. It does its job, but the code was cleaner before.
it is completely fine by me, I don't think you could fix in a
different way. If you have no objections, I can push the patch.
Regards,
Giuseppe