bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#60489: Programs should exit after EIO from FICLONE or copy_file_rang


From: Pádraig Brady
Subject: bug#60489: Programs should exit after EIO from FICLONE or copy_file_range()
Date: Mon, 2 Jan 2023 16:22:03 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.0

On 02/01/2023 13:28, Andreas Schwab wrote:
On Jan 02 2023, Pádraig Brady wrote:

+          /* Note error set is consistent with copy_file_range().  */
+          bool no_clone_attempted = errno == ENOSYS || is_ENOTSUP (errno)
+                                    || errno == EINVAL || errno == EBADF
+                                    || errno == EXDEV || errno == ETXTBSY;

Should this be refactored to avoid duplication?

Yes good call.
We should also refactor the handling of clone failure
to also apply to the usage of fclonefileat() on macOS.

Updated patch attached.

cheers,
Pádraig

Attachment: copy-clone-fail.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]