Re: Automake testsuite misuses DejaGnu

[Jacob Bachmeyer]

Jim Meyering wrote:
> On Sun, Jul 11, 2021 at 9:03 PM Jacob Bachmeyer <jcb62281@gmail.com> wrote:
>   
> > [...]
> >
> > The affected tests are:  check12, dejagnu3, dejagnu4, dejagnu5,
> > dejagnu6, dejagnu7, dejagnu-absolute-builddir, dejagnu-relative-srcdir,
> > dejgnu-siteexp-extend, dejagnu-siteexp-useredit.
> >
> > [...]
> >     
>
> Thank you for the analysis and heads-up.
> I see that Fedora 34 currently has only dejagnu-1.6.1.
> If this is something you can help with now, I can certainly wait a few days.
>
> Even a sample fix for one of the currently-failing tests would be helpful.
>   

That is part of the problem:  I have a patch, but applying it will cause 
the tests to fail with DejaGnu 1.6.1.  Older versions of DejaGnu require 
$srcdir to be exactly the root of the testsuite, while 1.6.3 accepts a 
testsuite in $srcdir or ${srcdir}/testsuite; the latter is needed to 
allow Automake to invoke DejaGnu from the top-level in the tree.

I expect to have time to try a recursive make solution later tonight or 
tomorrow.  Do I understand correctly that I will need to add "SUBDIRS = 
testsuite" to the top-level TEST_CASE/Makefile.am in the test case and 
move the "AUTOMAKE_OPTIONS = dejagnu" and "DEJATOOL" definitions to 
TEST_CASE/testsuite/Makefile.am to get Automake to invoke DejaGnu in the 
testsuite subdirectory instead of top-level?


-- Jacob