[Adonthell-commits] [ksterker/adonthell] fd8e52: base: cast char buffer to string to avoid ambiguit...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/ksterker/adonthell
  Commit: fd8e521158d8f2c7b7ade0bed4eb5556180328be
      
https://github.com/ksterker/adonthell/commit/fd8e521158d8f2c7b7ade0bed4eb5556180328be
  Author: Chris Frey <address@hidden>
  Date:   2012-06-08 (Fri, 08 Jun 2012)

  Changed paths:
    M src/base/file.cc

  Log Message:
  -----------
  base: cast char buffer to string to avoid ambiguity

The gcc compiler on sid actually warned about this, and it looks
like it was trying to do bitwise operations on the char, since
there doesn't appear to be any overload for char, only string.


  Commit: b5478081b43e1ac35686a482bcb6a3d32e445bcb
      
https://github.com/ksterker/adonthell/commit/b5478081b43e1ac35686a482bcb6a3d32e445bcb
  Author: Chris Frey <address@hidden>
  Date:   2012-06-08 (Fri, 08 Jun 2012)

  Changed paths:
    M src/base/savegame.cc

  Log Message:
  -----------
  base: fixed easy signed/unsigned comparison warning


  Commit: ccdd2158a16819e9fd4e79221025ca45d70fc670
      
https://github.com/ksterker/adonthell/commit/ccdd2158a16819e9fd4e79221025ca45d70fc670
  Author: Chris Frey <address@hidden>
  Date:   2012-06-08 (Fri, 08 Jun 2012)

  Changed paths:
    M src/gfx/surface.cc

  Log Message:
  -----------
  gfx: fixed unused variable error, and missing error return code


  Commit: 9dc3077ec03ccae4ae4ccd9e4b1cec2ebc24b4d3
      
https://github.com/ksterker/adonthell/commit/9dc3077ec03ccae4ae4ccd9e4b1cec2ebc24b4d3
  Author: Chris Frey <address@hidden>
  Date:   2012-06-08 (Fri, 08 Jun 2012)

  Changed paths:
    M src/gui/conversation.cc

  Log Message:
  -----------
  gui: fixed constructor variable warning (initialized in different order)


  Commit: a029e3e37f81851cd63bf95914504ec870b35458
      
https://github.com/ksterker/adonthell/commit/a029e3e37f81851cd63bf95914504ec870b35458
  Author: Chris Frey <address@hidden>
  Date:   2012-06-08 (Fri, 08 Jun 2012)

  Changed paths:
    M src/gui/decoration.cc
    M src/rpg/quest_event_manager.cc
    M src/world/area.cc

  Log Message:
  -----------
  Fixed unused variable warnings


  Commit: b869fe51eea8c6b6944641172a9b1b034bf29749
      
https://github.com/ksterker/adonthell/commit/b869fe51eea8c6b6944641172a9b1b034bf29749
  Author: Chris Frey <address@hidden>
  Date:   2012-06-08 (Fri, 08 Jun 2012)

  Changed paths:
    M src/gui/decoration.h

  Log Message:
  -----------
  gui: fixed missing virtual destructor in base class

This class was being used for deletion via "delete Factory"
elsewhere.


  Commit: b4abaed9afbfa4e509c68846379f9c1f401d2d7b
      
https://github.com/ksterker/adonthell/commit/b4abaed9afbfa4e509c68846379f9c1f401d2d7b
  Author: Chris Frey <address@hidden>
  Date:   2012-06-08 (Fri, 08 Jun 2012)

  Changed paths:
    M src/gui/font.cpp

  Log Message:
  -----------
  gui: fixed assignment-in-if-statement warning, adding parentheses


  Commit: 8ca5c455b7302203ee561f9197e8f72e0eb2c3d5
      
https://github.com/ksterker/adonthell/commit/8ca5c455b7302203ee561f9197e8f72e0eb2c3d5
  Author: Chris Frey <address@hidden>
  Date:   2012-06-08 (Fri, 08 Jun 2012)

  Changed paths:
    M src/gui/font.cpp

  Log Message:
  -----------
  gui: fixed potential use of variable without initialization


  Commit: 4cfd5d9d36bff67d897c6cfc83c99835531b3b6b
      
https://github.com/ksterker/adonthell/commit/4cfd5d9d36bff67d897c6cfc83c99835531b3b6b
  Author: Chris Frey <address@hidden>
  Date:   2012-06-08 (Fri, 08 Jun 2012)

  Changed paths:
    M src/gui/window_manager.cc

  Log Message:
  -----------
  gui: fixed missing return value in non-void function


  Commit: 11e2f231f0ed8e5c4569697d65ed43a4e9204113
      
https://github.com/ksterker/adonthell/commit/11e2f231f0ed8e5c4569697d65ed43a4e9204113
  Author: Chris Frey <address@hidden>
  Date:   2012-06-08 (Fri, 08 Jun 2012)

  Changed paths:
    M src/python/script.cc

  Log Message:
  -----------
  python: fixed if/else ambiguity by adding braces


  Commit: e3074cdc171d307d3c71a98cbc269764e74217c5
      
https://github.com/ksterker/adonthell/commit/e3074cdc171d307d3c71a98cbc269764e74217c5
  Author: Chris Frey <address@hidden>
  Date:   2012-06-08 (Fri, 08 Jun 2012)

  Changed paths:
    M src/rpg/pathfinding_costs.cc

  Log Message:
  -----------
  rpg: fixed typo which took address of iterator instead of dereferencing it


  Commit: 4b6c073ed822450b664168cb9e1ef2826e466410
      
https://github.com/ksterker/adonthell/commit/4b6c073ed822450b664168cb9e1ef2826e466410
  Author: Chris Frey <address@hidden>
  Date:   2012-06-08 (Fri, 08 Jun 2012)

  Changed paths:
    M src/rpg/pathfinding_costs.h

  Log Message:
  -----------
  rpg: removed ^M leftovers from pathfinding_costs.h header file


Compare: https://github.com/ksterker/adonthell/compare/fdec266...4b6c073