Re: [Acl-devel] [ATTR] [PATCH] Cleanup visibility of API functions

[Andreas Grünbacher]

Yury,

2016-03-02 15:14 GMT+01:00 Yury Usishchev <address@hidden>:
> Hello!
>
> As discussed in 
> http://lists.nongnu.org/archive/html/acl-devel/2016-02/msg00000.html thread 
> I've prepared patch set for
> cleaning up visibility of API functions in attr.
>
> 0001-Cleanup-config.h-usage.patch:
>
>   adds config.h include before all other includes in all source files.
>
> 0002-Cleanup-visibility-of-API-functions.patch:
>
>   add m4 script from acl tree that checks for visibility attribute.
>   add call to new m4 macro from configure.ac
>   add visibility attribute to API functions same way it was added in acl.
>
> Note: functions from syscalls.c are exported through linker script 
> libattr.lds and visibility needs to be set explicitly
> Note2: pragma usage in syscalls.c seems cleaner
> Note3: internal headers usage cleanup in attr was not needed
>
> Could you review attached patches please?

This looks okay; I've applied it.

Thanks,
Andreas