Re: 2.0.17 and deprecated GTK APIs

[Greg Troxel]

On 2020-02-28 18:57, Andy Stewart wrote:

> I just checked my system, and I have gtk2 2.24.32-1ubuntu1 installed.
> For glib2, I have version 2.56.4-0ubuntu0.18.04.4.
>
> I rebuilt the source code and saw no issues with these revs on Ubuntu 
> 18.04.4.

Thanks for checking.

Your glib2 is quite old, but you are running Ubuntu 18.04, which is LTS 
aka "intentionally running code that was released 2 years ago, with 
micro updates only", as I understand it.  Perfectly fine for you to do 
that of course, but xlog building in that environment merely shows that 
it builds with 2ish-year-old code.  (1.5 in this case, as it seems up to 
date with 2.56, but not moved to 2.58 from 2018-09, which is the LTS plan.)

As I see it, the latest formal release of a package should always build 
ok when each dependency is the latest formal release of that dependency, 
and ideally somewhat older.  If not, a release that does build is 
overdue.  (Presumably 18.04 people use the xlog that was current when 
18.04 was released, as the LTS plan would indicate, but it also seems 
that newer ones and even master/head is ok.)

We have two reports (me on NetBSD/pkgsrc and KC0BUF on slackware) that 
xlog fails with up-to-date glib2.  So it's pretty clearly not an 
OS/packaging environment problem, and it's also clear by inspection from 
the gtk2 headers.

So it seems the thing to do is either to turn off -Werror, or less 
drastically to add -Wno-deprecated-declarations into configure.ac.  (I 
am using a pkgsrc facility to basically edit flags on the fly, which is 
good for working around upstream issues, but obviously not something 
that can apply to xlog.)   Reading configure.ac, that seems easy.
My control file lines are:

# Work around https://savannah.nongnu.org/bugs/index.php?57920
_WRAP_EXTRA_ARGS.CC+=   -Wno-deprecated-declarations
CWRAPPERS_APPEND.cc+=   -Wno-deprecated-declarations

which is indeed the same thing for two different wrapper methods.

I can send a patch if that's helpful, given that above.

Plus perhaps file a bug with gtk2 that the latest release fails with 
glib2.  This feels like tilting at windmills; it is very hard to even 
find their bugtracker and the whole situation seems hard to follow. 
(Which I don't enjoy saying as I have been a gtk fan for at least 20 
years.)   Which leads to needing to change xlog to gtk3.

73 de n1dam