xbindkeys-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Correctly handling failed execlp calls


From: Vojtěch Štěpančík
Subject: Correctly handling failed execlp calls
Date: Sun, 5 Nov 2023 11:22:39 +0000

This is probably a very minor edge-case, but when xbindkeys fails to exec `sh` in a forked process, it just jumps back into the event loop, so with every failed exec there's now a new xbindkeys process, which eventually leads to a failed assert in xcb and a crash.

The correct behavior is to kill the forked process when exec returns, because it only returns when it fails. I'm attaching a patch.

Vojta

Attachment: exec_fail.patch
Description: exec_fail.patch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]