[Xbindkeys-devel] [PATCH 0/2] Guile-2.0 support

[Hans-Peter Deifel]

Hello,

Trying to compile Xbindkeys against Guile-2.0 gives the following error:

make  all-am
make[1]: Entering directory `foo'
gcc -DHAVE_CONFIG_H -I.    -g -O2  -DFORK_FLAG=1 -DGUILE_FLAG=1 -pthread 
-I/usr/include/guile/2.0 -I/usr/include/gc   -I. -Wall -g -O2 -MT options.o -MD 
-MP -MF .deps/options.Tpo -c -o options.o options.c
options.c:31:22: error: guile/gh.h: No such file or directory
options.c: In function 'get_rc_guile_file':
options.c:865: warning: 'scm_makfrom0str' is deprecated (declared at 
/usr/include/guile/2.0/libguile/deprecated.h:713)
options.c: In function 'extract_key':
options.c:900: warning: 'scm_i_object_length' is deprecated (declared at 
/usr/include/guile/2.0/libguile/deprecated.h:204)
options.c:902: warning: 'scm_i_object_chars' is deprecated (declared at 
/usr/include/guile/2.0/libguile/deprecated.h:199)
options.c:944: warning: 'scm_i_object_length' is deprecated (declared at 
/usr/include/guile/2.0/libguile/deprecated.h:204)
options.c:946: warning: 'scm_i_object_chars' is deprecated (declared at 
/usr/include/guile/2.0/libguile/deprecated.h:199)
options.c: In function 'xbindkey_wrapper':
options.c:1003: warning: 'scm_i_object_length' is deprecated (declared at 
/usr/include/guile/2.0/libguile/deprecated.h:204)
options.c:1004: warning: 'scm_i_object_chars' is deprecated (declared at 
/usr/include/guile/2.0/libguile/deprecated.h:199)
options.c:1004: warning: 'scm_i_object_length' is deprecated (declared at 
/usr/include/guile/2.0/libguile/deprecated.h:204)
options.c:1005: warning: 'scm_i_object_length' is deprecated (declared at 
/usr/include/guile/2.0/libguile/deprecated.h:204)
options.c: In function 'xbindkey_function_wrapper':
options.c:1054: warning: implicit declaration of function 'gh_procedure_p'
options.c: In function 'run_command_wrapper':
options.c:1095: warning: 'scm_i_object_length' is deprecated (declared at 
/usr/include/guile/2.0/libguile/deprecated.h:204)
options.c:1096: warning: 'scm_i_object_chars' is deprecated (declared at 
/usr/include/guile/2.0/libguile/deprecated.h:199)
options.c:1096: warning: 'scm_i_object_length' is deprecated (declared at 
/usr/include/guile/2.0/libguile/deprecated.h:204)
options.c:1097: warning: 'scm_i_object_length' is deprecated (declared at 
/usr/include/guile/2.0/libguile/deprecated.h:204)
make[1]: *** [options.o] Error 1
make[1]: Leaving directory `foo'
make: *** [all] Error 2


So I made two patches. The first one fixes the compile-error and is rather
straightforward. The second tries to fix the warnings, but I don't know if it's
completely right.

I've been using them for a few days without any problem so far and I also tried
them (compilation and a few basic functions) with different guile versions.

Here is a table showing what works where:

 | Patches:    | none | 1 | 2 |
 |-------------+------+---+---|
 | Guile 1.6.8 |  X   | X |   |
 | Guile 1.8.8 |  X   | X | X |
 | Guile 2.0.0 |      | X | X |

Regards,
HP

PS: Something went wrong, while sending this patch series. I'll try again.

Hans-Peter Deifel (2):
  Remove reference to guile's old GH interface
  Replace some deprecated guile functions

 options.c |   35 ++++++++++++++++++-----------------
 1 files changed, 18 insertions(+), 17 deletions(-)

-- 
1.7.3.4