Re: wget | Add libproxy support (!35)

[Jan-Michael Brummer (@jbrummer_vw)]

Jan-Michael Brummer commented on a discussion on src/retr.c: 
https://gitlab.com/gnuwget/wget/-/merge_requests/35#note_1604878982

>      }
>    if (!proxy || !*proxy)
> +#ifdef HAVE_LIBPROXY
> +    {
> +       pxProxyFactory *pf = px_proxy_factory_new ();
> +       char direct[] = "direct://";
> +       int i;
> +
> +       if (!pf)
> +         {
> +            debug_logprintf (_("Allocating memory for libproxy failed"));
> +            return NULL;
> +         }
> +
> +       debug_logprintf (_("asking libproxy about url '%s'\n"), u->url);
> +       char **proxies = px_proxy_factory_get_proxies (pf, u->url);

proxies is always set, as in cases where there are no proxies at all 
"direct://" is returend. But nevertheless, be safe here and check it as well.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget/-/merge_requests/35#note_1604878982
You're receiving this email because of your account on gitlab.com.