wget2 | * libwget/dns.c (resolve): Restrict socket type to SOCK_STREAM on illumos and Solaris (!529)

[Andy Fiddaman (@citrus-it)]

Andy Fiddaman created a merge request: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/529

Project:Branches: citrus-it/wget2:illumos to gnuwget/wget2:master
Author:   Andy Fiddaman




It seems that illumos and Solaris take a very literal view of RFC3493's 
requirement to perform no lookups in `getaddrinfo()` if `AI_NUMERICSERV` is 
specified and the socket type is not specified. They return `EAI_NONAME ` in 
this case. These platforms will likely need the same workaround as is noted as 
a TODO for Windows.

I am planning to submit a change to illumos to update `getaddrinfo()` 
(https://www.illumos.org/issues/11616) but that could take some years to filter 
down into the LTS releases of various illumos distributions (and does not 
address Solaris).

### Approver's checklist:

* [ ] The author has submitted the FSF Copyright Assignment and is listed in 
AUTHORS
* [ ] There is a test suite reasonably covering new functionality or 
modifications
* [ ] Function naming, parameters, return values, types, etc., are consistent 
with existing code
* [ ] This feature/change has adequate documentation added (if appropriate)
* [ ] No obvious mistakes / misspelling in the code

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/529
You're receiving this email because of your account on gitlab.com.