[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: wget | * src/url.c: fix length check (!17)
From: |
Tim Rühsen |
Subject: |
Re: wget | * src/url.c: fix length check (!17) |
Date: |
Sat, 27 Feb 2021 12:29:41 +0000 |
Tim Rühsen commented:
Great, thank you for the patch :-)
Could you elaborate a bit what exactly the problem is that you are trying to
solve ?
The most appreciated way would be to add a test that fails with the current
code and succeeds with yours.
Some minor things
- Please make sure that the CI succeeds. From what I can see it's `make
syntax-check` that fails due to a trailing space somewhere. Most editors have a
configuration option for "remove trailing whitespace on save".
- Please make sure that your commit message is GNU style (see `git log` for
examples).
- We need you assigning the copyright of your code changes to the FSF (see the
attachment).
[request-assign.future](/uploads/3cbb202c63dcb57a74c661c974d1d36d/request-assign.future)
--
Reply to this email directly or view it on GitLab:
https://gitlab.com/gnuwget/wget/-/merge_requests/17#note_518517162
You're receiving this email because of your account on gitlab.com.