[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: wget2 | Added --convert-file-only handling (!456)
From: |
Archit Pandey |
Subject: |
Re: wget2 | Added --convert-file-only handling (!456) |
Date: |
Mon, 28 Oct 2019 19:33:11 +0000 |
Archit Pandey commented on a discussion on src/wget.c:
https://gitlab.com/gnuwget/wget2/merge_requests/456#note_236659807
> plugin_db_forward_url_verdict_free(&plugin_verdict);
> }
>
> +/**
> + * Function to handle the option --convert-file-only
> + * Converts only the filename part of URLs found in the body of a page
> + * e.g. when used with -E
> + * //localhost/index becomes //localhost/index.html
> + */
> +static void convert_file_only(void)
Yes, I think that combining the functions is one option. However, it would make
an already complicated function `convert_links` more complicated.
Perhaps we could move the common code from `convert_links` and
`convert_file_only` into a new function and then reuse their calls.
On a side note, we could refactor a lot of functions for better readability.
--
Reply to this email directly or view it on GitLab:
https://gitlab.com/gnuwget/wget2/merge_requests/456#note_236659807
You're receiving this email because of your account on gitlab.com.
- wget2 | Added --convert-file-only handling (!456), Archit Pandey, 2019/10/28
- Re: wget2 | Added --convert-file-only handling (!456), Archit Pandey, 2019/10/28
- Re: wget2 | Added --convert-file-only handling (!456), Archit Pandey, 2019/10/28
- Re: wget2 | Added --convert-file-only handling (!456), Tim Rühsen, 2019/10/28
- Re: wget2 | Added --convert-file-only handling (!456), Tim Rühsen, 2019/10/28
- Re: wget2 | Added --convert-file-only handling (!456), Tim Rühsen, 2019/10/28
- Re: wget2 | Added --convert-file-only handling (!456), Tim Rühsen, 2019/10/28
- Re: wget2 | Added --convert-file-only handling (!456), Tim Rühsen, 2019/10/28
- Re: wget2 | Added --convert-file-only handling (!456), Tim Rühsen, 2019/10/28
- Re: wget2 | Added --convert-file-only handling (!456),
Archit Pandey <=