[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Wget-dev] wget2 | --no-if-modified-since implementation & tests for
|
From: |
DalmeGNU |
|
Subject: |
Re: [Wget-dev] wget2 | --no-if-modified-since implementation & tests for both --no-if-modified-since and -N (!439) |
|
Date: |
Wed, 21 Aug 2019 11:16:54 +0000 |
DalmeGNU commented:
Looks ready. However, I have some questions / comments:
- We may add WGET_GCC_NONNULL_ALL to get_file_lmtime(), as I don't know what is
this for I cannot say.
- I haven't written tests for `--accept-regex & --reject-regex`, I think the
ones for `--accept & --reject` are enough
- There are two commented tests in `test-include-and-exclude-directories.c`.
I've run those and they passed, but until !440 is merged they break the
pipeline. Before merge I would like to uncomment them.
- Pipeline has 4 failed jobs, but it's OK
--
Reply to this email directly or view it on GitLab:
https://gitlab.com/gnuwget/wget2/merge_requests/439#note_206267876
You're receiving this email because of your account on gitlab.com.
- [Wget-dev] wget2 | WIP: --no-if-modified-since implementation & tests for both --no-if-modified-since and -N (!439), DalmeGNU, 2019/08/15
- Re: [Wget-dev] wget2 | WIP: --no-if-modified-since implementation & tests for both --no-if-modified-since and -N (!439), Tim Rühsen, 2019/08/16
- Re: [Wget-dev] wget2 | WIP: --no-if-modified-since implementation & tests for both --no-if-modified-since and -N (!439), DalmeGNU, 2019/08/18
- Re: [Wget-dev] wget2 | --no-if-modified-since implementation & tests for both --no-if-modified-since and -N (!439),
DalmeGNU <=
- Re: [Wget-dev] wget2 | --no-if-modified-since implementation & tests for both --no-if-modified-since and -N (!439), Tim Rühsen, 2019/08/22
- Re: [Wget-dev] wget2 | --no-if-modified-since implementation & tests for both --no-if-modified-since and -N (!439), Tim Rühsen, 2019/08/22
- Re: [Wget-dev] wget2 | --no-if-modified-since implementation & tests for both --no-if-modified-since and -N (!439), DalmeGNU, 2019/08/22
- Re: [Wget-dev] wget2 | --no-if-modified-since implementation & tests for both --no-if-modified-since and -N (!439), Tim Rühsen, 2019/08/22