Re: [Wget-dev] wget2 | GSoC'18: Support DNS over HTTPS - Discussions (#378)

[Aniketh Girish]

Hi @darnir @rockdaboot , 

The basic idea right now is to store the IP from the response to the addrinfo 
struct. What I have done right now is that I took the IP, stored it into an 
addr_in struct and passed onto addrinfo struct. But it is ugly and I don't even 
think that would work in first place! 
 
Check the commit: 
https://gitlab.com/Aniketh01/wget2/commit/a68e8d33decfb941d1934830fd11ade2004543de

>From what I understood from the discussion is that we need to fill in the 
>result addrinfo without the hints and the getaddrinfo() and return that 
>addrinfo structure. But there isn't any easy wasy I believe. 

So, what I have in mind is to create an addrinfo "clone" struct that looks like 
the regular one but can be made up by us so we can implement alternative 
getaddrinfo() calls easily.

And about returning an addrinfo with all the stored datas, regular addrinfo 
struct is freed with freeaddrinfo() which our made up one then can't be. 

I see to implement wget2_freeaddrinfo() function that checks if the pointer is 
our made-up addrinfo data or a "real" addrinfo and then clean it up the way we 
think it should be.

Let me know what the maintainers would like to have the architecture to be. I 
will send in an MR separately for the addrinfo struct if that is what we need 
to have.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/issues/378#note_99625585
You're receiving this email because of your account on gitlab.com.