[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Weechat-dev] [patch #7992] Support IPv6 xfers

From: Andrew Potter
Subject: [Weechat-dev] [patch #7992] Support IPv6 xfers
Date: Tue, 02 Apr 2013 22:15:46 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.22 (KHTML, like Gecko) Chrome/25.0.1364.172 Safari/537.22


                 Summary: Support IPv6 xfers
                 Project: WeeChat
            Submitted by: talisein
            Submitted on: Tue 02 Apr 2013 10:15:45 PM GMT
                Category: xfer plugin
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                IRC nick: talisein



This patch depends on patch #7974

This patch adds support for IPv6 xfers.

There are two primary changes to weechat_network_connect_to():
* Because a ulong obviously can't transfer an IPv6 address, struct addrinfo*
is used instead, and the port parameter is unused as it would be redundant,
ignored, or confusing.
* Because the proxy may be at an IPv4 address and the target IPv6--or vice
versa--the socket() call must be made in network_connect_to() so that it is
created in the correct family. So network_connect_to() now returns the socket

I could use some specific feedback in two areas:
* I've changed remote_address and local_address to (struct addrinfo_storage).
It could be (struct addrinfo*) instead, but I'm unsure which most desirable
with regard to style.
* I'd like to introduce a timeout parameter to network_connect_to(), a struct
timeval* that select() would use in network_connect(). I don't know if that
should be in a separate patch, or if you want all the API change at once.

As the patch is a little lengthy, it might be easier to leave line-by-line
comments on github:

I've tested vanilla sending/receiving via IPv4 and IPv6, but not setting
own_ip and using a proxy.


File Attachments:

Date: Tue 02 Apr 2013 10:15:45 PM GMT  Name: 0002-xfer-Support-IPv6-DCC.patch 
Size: 47kB   By: talisein



Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]