[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [wdiff-bugs] [PATCH] maint: remove a signle trailing blank

From: Martin von Gagern
Subject: Re: [wdiff-bugs] [PATCH] maint: remove a signle trailing blank
Date: Wed, 27 Jan 2010 17:06:36 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100125 Thunderbird/3.0.1

Hello Jim!

On 27.01.2010 14:26, Jim Meyering wrote:
> I noticed that syntax-check wasn't passing, so fixed it for you:

Thanks for noticing and sending the patch. The newline at the end of the
file was deliberate, as there used to be a few lines there from
gettextize, and if future gettextize versions or other tools repeat that
approach, I want their cruft separated from the other rules.

As you sent me a plain text patch, and not a bzr merge directive as "bzr
send" generates it <http://tinyurl.com/y9v9294>, I couldn't simply merge
your commit into my bzr branch. So instead I applied the diff as it is
and committed it myself, naming you as the author. bzr does distinguish
between author and committer.

Unfortunately, I found out that the ChangeLog we generate from the bzr
log and ship with the tarball currently only mentions committers, not
authors. I think that's a bug in bzr, and just filed a bug report for it
<https://launchpad.net/bugs/513322>. Even with a merge directive, the
same issue would happen, as the ChangeLog only lists the main line
history, so I'd list side line commiters as authors in the merge.

I guess for this single blank it doesn't really matter, but for larger
contributions in the future it's good to be aware that proper
attribution in the ChangeLog doesn't work yet.

 Martin von Gagern

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]