Re: [vile] xvile selecting newline

[Thomas Dickey]

On Tue, May 20, 2008 at 05:10:34PM -0400, Thomas Dickey wrote:
> On Tue, 20 May 2008, Eric Krohn wrote:
>
>>
>> About a month ago when I updated my Debian box, I replaced xvile 9.5s
>> with 9.6i and noticed something disappointing.  With xvile 9.5s and older,
>> when I swept out a selection with the mouse, if the end of line (newline)
>> was selected, it would be highlighted as an inverse video space just right
>> of the last character of the line.  With xvile 9.6i and newer, there is no
>> visual indicator as to whether the newline is included in the selection.
>> If I am careful with my mousing, I can include the newline or not in the
>> selection, but I cannot tell for sure until I paste it.
>>
>> Typically, I paste such selections into a shell window, not back into
>> xvile, and it is nice to know ahead of time whether the newline will be
>> included.
>>
>> Is there any way to get the old visual indicator back?
>
> probably (as a bug-fix).  Scattered off-by-ones like that I suspect are
> due to the wide-character changes.

fwiw, it was introduced by a bug-fix:

 20080113 (c)
         > Tom Dickey:
         + another fix for offs2col0(), to reduce an off-by-one limit check.

...and the detailed comment (for display.c):

        revision 1.468
        date: 2008/01/13 22:24:57;  author: tom;  state: Exp;  lines: +3 -3
        I got this when editing a file in xterm, toggling the list-mode:
        ==26005== Use of uninitialised value of size 4
        ==26005==    at 0x8073593: column_sizes (basic.c:1097)
        ==26005==    by 0x80870AB: offs2col0 (display.c:1548)
        ==26005==    by 0x808CAD3: update_window_attrs (display.c:1568)
        ==26005==    by 0x808E99B: update (display.c:3664)
        ==26005==    by 0x807213C: main (main.c:915)
        ----TD: reduce the off-by-one down (since the limit obviously is too 
high).
        There might be some special case I have to route through this, but won't
        know til more testing.

I'd noticed recently that there was something odd about the highlighting
of selected lines, but not realized exactly what it was.

-- 
Thomas E. Dickey <address@hidden>
http://invisible-island.net
ftp://invisible-island.net

signature.asc
Description: Digital signature