[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Selectively localized images [was: [ #604705] self-inconsiste

From: Yavor Doganov
Subject: Re: Selectively localized images [was: [ #604705] self-inconsistent...]
Date: Tue, 28 Dec 2010 20:22:31 +0200
User-agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Goj┼Ź) APEL/10.7 Emacs/23.2 (i486-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)

Ineiev wrote:
> > Indeed, it is not :(
> Next iteration, hopefully fixing that issue:

Thanks, but I'm reluctant to consider this approach, unless it is
really the final resort.

There should be no reason to add the whole junk in the .po, e.g.

  msgid "<!-- translate this image --> <img src=\"foo.png\" alt=\"\" />"

The possibility for a mistake on translators' part is significant.
Plus, it probably wont' work if <img> is within another top-level
element.  And, last but not least, it's going to be a nuisance.

What I'm thinking about is automatic prepending of .LANG (if the file
exists) without translator's intervention.  I'm not sure how it should
be done exactly; please give me some time.

Some general stylistic nitpicking for future reference (not your fault
at all, it really should be in something like a HACKING file):

1) Always put spaces around the equal sign in variable assignments.

2) Use automatically expanded variables (`:='), unless the other types
   are actually needed.  It makes execution faster, and a complex
   makefile like ours easier to read.

3) Dash is preferred as lexical separator in variable names, as
   opposed to underscore (ala Lisp/Scheme, but unlike C).

4) There's not much sense to use variables if they contain command
   sequences that are used only once in the rules.  It just makes the
   makefile harder to grok.

5) When you continue lines in the recipe, indent the next row with two
   spaces; it helps the eye understand quickly that this is one
   command rather than two.  E.g., instead of

   $(FOO) --bar $< --baz $@; \
   $(RM) address@hidden

   $(FOO) --bar $< --baz $@; \
     $(RM) address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]