[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Strange behavior of `file-exists-p` on latest Tramp version
From: |
Basil L. Contovounesios |
Subject: |
Re: Strange behavior of `file-exists-p` on latest Tramp version |
Date: |
Thu, 02 May 2024 10:24:21 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hi Ruiyang, Michael,
Ruiyang Wu [2024-05-01 15:55 -0400] wrote:
> It looks like Oleh is no longer maintaining ivy-mode. I have cc’ed the current
> maintainer and opened a pull request (https://github.com/abo-abo/swiper/pull/
> 3046) on their GitHub repository.
[...]
> On Mar 6, 2023, at 12:27 PM, Michael Albinus <michael.albinus@gmx.de>
> wrote:
[...]
> *** /home/albinus/.emacs.d/elpa/ivy-0.13.4/ivy.el~ 2021-03-23
> 15:42:21.107225608 +0100
> --- /home/albinus/.emacs.d/elpa/ivy-0.13.4/ivy.el 2023-03-06
> 18:06:49.507257395 +0100
> ***************
> *** 1029,1034 ****
> --- 1029,1036 ----
> (defvar tramp-completion-mode)
> (with-no-warnings
> (let* ((tramp-completion-mode t)
> + (non-essential t)
> + minibuffer-completing-file-name
> (file (expand-file-name
> (if (> ivy--length 0) (ivy-state-current
> ivy-last) ivy-text)
> ivy--directory)))
>
> I've added (non-essential t), because this setting shall be used
> instead
> of (tramp-completion-mode t) in newer Tramp versions. And I've added
> minibuffer-completing-file-name (being nil), because it changes Tramp
> completion (when non-nil) since Tramp 2.6.0.2. That Tramp change is
> already on GNU ELPA, and it will appear with Emacs 29.2.
>
> Could you please confirm, that this works for you? I'll be in contact
> with the ivy-mode maintainer (added to Cc) then for a final solution.
[ Sorry for missing this last year; I haven't been paying very close
attention to the mailing lists lately, especially if I'm not in
To/Cc. ]
Thank you both for spotting, fixing, and following up on this!
Now coming to a GNU ELPA near you:
Fix compatibility with Tramp 2.6.0.2 and above
4c1690c5fe 2024-05-02 10:08:22 +0200
https://git.sv.gnu.org/cgit/emacs/elpa.git/commit/?id=4c1690c5fe
--
Basil