[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] Regression building GMP with tcc, bisected

From: Michael Matz
Subject: Re: [Tinycc-devel] Regression building GMP with tcc, bisected
Date: Mon, 6 Jul 2020 14:14:56 +0200 (CEST)
User-agent: Alpine 2.21 (LSU 202 2017-01-01)

Hello Herman,

On Mon, 6 Jul 2020, Herman ten Brugge via Tinycc-devel wrote:

Patch below should fix the problem on mob.
I can commit it if it works for you.

Please find a different way, without strcmp in next_nomacro1. In principle it shouldn't matter how the file is named, and if the cmdline buffer setup somehow makes a difference to normal files than that should be changed, so that next_nomacro1 behaves as normal.



diff --git a/tccpp.c b/tccpp.c
index 94f8b02..ae8579b 100644
--- a/tccpp.c
+++ b/tccpp.c
@@ -2643,7 +2643,8 @@ static inline void next_nomacro1(void)
                 tok_flags |= TOK_FLAG_EOF;
                 tok = TOK_LINEFEED;
                 goto keep_tok_flags;
-            } else if (!(parse_flags & PARSE_FLAG_PREPROCESS)) {
+            } else if (strcmp(file->filename, "<command line>") &&
+                       !(parse_flags & PARSE_FLAG_PREPROCESS)) {
                 tok = TOK_EOF;
             } else if (s1->ifdef_stack_ptr != file->ifdef_stack_ptr) {
                 tcc_error("missing #endif");

On 2020-07-06 03:22, John Scott wrote:
 tcc 0.9.27 works, but current mob fails during GMP's configure step. For
 use --disable-assembly and --disable-static, and it fails on
 checking how to define a 32-bit word... configure: error: cannot determine
 to define a 32-bit word

 I don't know for certain that this is tcc's fault; it could be a normal
 that broke the configure script's heuristics. You can fetch GMP from

 Here's the culprit:
 72729d8e360489416146d6d4fd6bc57c9c72c29b is the first bad commit
 commit 72729d8e360489416146d6d4fd6bc57c9c72c29b
 Author: grischka <grischka>
 Date:   Wed Dec 11 00:37:18 2019 +0100

 allow libtcc states to be used concurrently

 This allows creation of TCCStates and operation with API
 calls independently from each other, even from threads.

 Frontend (option parsing/libtcc.c) and backend (linker/tccelf.c)
 now depend only on the TCCState (s1) argument.

 Compilation per se (tccpp.c, tccgen.c) is still using
 globals for convenience.  There is only one entry point
 to this section which is tcc_compile() which is protected
 by a semaphore.

 There are some hacks involved to avoid too many changes,
 as well as some changes in order to avoid too many hacks ;)

 The test libtcc_test_mt.c shows the feature.  Except this
 new file the patch adds 87 lines overall.

Tinycc-devel mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]