|
From: | Michael Matz |
Subject: | Re: [Tinycc-devel] Annoying new warning |
Date: | Sat, 6 May 2017 21:28:21 +0200 (CEST) |
User-agent: | Alpine 2.20 (LSU 67 2015-01-07) |
Hi, On Sat, 6 May 2017, Christian Jullien wrote:
I'm a bit confused now. As documented and pointed out by grischka /* only for x86 */ union ldouble_long { long double ld; struct { unsigned long long lower; unsigned short upper; } l; }; ldouble_long should only be used by x86. So far so good. So I commented out using #if unsigned long long __fixunsxfdi (long double a1) and, by transitive closure long long __fixxfdi (long double a1) { long long ret; int s; ret = __fixunsxfdi((s = a1 >= 0) ? a1 : -a1); return s ? ret : -ret; }
Yes, that you did, and that's right. But that's not the only thing you did, look at your patch again. Your second '#if !defined(TCC_TARGET_ARM)' also surrounds and hence on arm comments out the implementations of __fixunsdfdi, __fixdfdi (after rename/move), and that's wrong. Note: df, not xf!
Ciao, Michael.
[Prev in Thread] | Current Thread | [Next in Thread] |