[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] lcall invalid hex code

From: David Mertens
Subject: Re: [Tinycc-devel] lcall invalid hex code
Date: Sun, 1 May 2016 19:46:47 -0400


I have a general request for the patches of yours that you submit in the future. Could you assume that I don't actually know much at all about compilers, but I would like to learn? That would be a useful assumption, because it's true. :-P

Speaking only for myself, I have no idea what this patch practically does. I can see that it changes one hex value in assembler-related stuff to something else, but I'm not given enough context to teach myself and make an assessment. What is invalid? Is the actual constant incorrect, or is the notation for it in the C code simply incorrect? What did it used to do before? Do you have any links for assembler op codes so that I might learn more?

Give me just enough context and I'll teach myself. Thanks!

On Sun, May 1, 2016 at 2:58 PM, Sergey Korshunoff <address@hidden> wrote:

diff --git a/i386-asm.h b/i386-asm.h
index 486cffe..637568b 100644
--- a/i386-asm.h
+++ b/i386-asm.h
@@ -213,7 +213,7 @@ ALT(DEF_ASM_OP1(jmp, 0xff, 0, OPC_JMP | OPC_WL, OPT_REGW))
 ALT(DEF_ASM_OP2(lcall, 0x9a, 0, 0, OPT_IM16, OPT_IM32))
-ALT(DEF_ASM_OP1(lcall, 0xff, 3, 0, OPT_EA))
+ALT(DEF_ASM_OP1(lcall, 0xff1f, 3, 0, OPT_EA))
 ALT(DEF_ASM_OP2(ljmp, 0xea, 0, 0, OPT_IM16, OPT_IM32))
 ALT(DEF_ASM_OP1(ljmp, 0xff, 5, 0, OPT_EA))

Tinycc-devel mailing list

 "Debugging is twice as hard as writing the code in the first place.
  Therefore, if you write the code as cleverly as possible, you are,
  by definition, not smart enough to debug it." -- Brian Kernighan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]