[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] [PATCH] fix potential bug in handling of case_reg

From: Thomas Preud'homme
Subject: Re: [Tinycc-devel] [PATCH] fix potential bug in handling of case_reg
Date: Wed, 18 Feb 2015 07:19:21 +0000
User-agent: KMail/4.14.1 (Linux/2.6.38-ac2-ac100; KDE/4.14.2; armv7l; ; )

Le lundi 16 février 2015, 12:41:02 Edmund Grimley Evans a écrit :
> What's the procedure for contributing to TCC? Should I first send a
> patch to this list and then push it to "mob" once someone has approved
> it?

There is no formal procedure in place right now. We have a branch (mob) where 
everybody can commit. My take on this is that it depends on your own confidence 
and the history of your past commit to tcc. I encourage people that don't have 
much experience in compilation or coding in general to go through patch 
review. This process is currently slow as we are very few reviewer with not 
much time but we do try our best.

Otherwise, you can commit directly but if there is a high number of problems 
with your commits, especially if it's trivial errors, it will be expected that 
you go through patch review until the quality of your patch improve.

Given your experience in compilation (disclaimer: we work in the same company 
and already met), I'd say just go ahead and commit to mob. Of course you are 
welcome to post for public review first if you want to make sure your patch 
follows tcc code style and use the right internal API for instance.

For what it's worth (my review skills are still modest), the patch looks good 
to me.

Best regards,


reply via email to

[Prev in Thread] Current Thread [Next in Thread]